Page MenuHomePhabricator

Escape newline chars in Docker output
AbandonedPublic

Authored by thcipriani on Jun 27 2017, 12:08 AM.
Referenced Files
Unknown Object (File)
Sat, Dec 2, 1:09 AM
Unknown Object (File)
Sat, Nov 25, 8:39 PM
Unknown Object (File)
Thu, Nov 23, 2:54 PM
Unknown Object (File)
Sat, Nov 18, 12:09 AM
Unknown Object (File)
Tue, Nov 14, 3:37 PM
Unknown Object (File)
Thu, Nov 9, 1:54 PM
Unknown Object (File)
Nov 3 2023, 1:57 PM
Unknown Object (File)
Oct 29 2023, 1:03 PM
Subscribers
None

Details

Reviewers
dduvall
mmodell
Group Reviewers
Release-Engineering-Team
Patch without arc
git checkout -b D695 && curl -L https://phabricator.wikimedia.org/D695?download=true | git apply
Summary

One current vulnerability is the ability to inject a newline character
into Dockerfile output. Currently, a yaml file like:

base: debian:jessie
apt:
  packages: [libjpeg, libyaml, "\n RUN touch /bin/hello-world"]

Results in a dockerfile with the line:

RUN touch /bin/hello-world

This provides a new function that escapes instructions

Diff Detail

Repository
rGBLBR Blubber
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Restricted Application added a reviewer: Release-Engineering-Team. · View Herald Transcript
Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript
Harbormaster completed remote builds in Restricted Buildable.Jun 27 2017, 12:08 AM
This revision is now accepted and ready to land.Jun 27 2017, 4:12 PM