This adds a new DockerInstruction interface that can be implmented by
different docker instructions. DockerInstruction implements a compile
method that returns escaped output for use in a dockerfile.
Fixes T167999
Details
Details
- Maniphest Tasks
- T167999: Escape Blubber config values when compiling to Dockerfile
- Reviewers
dduvall mmodell - Group Reviewers
Release-Engineering-Team - Commits
- rGBLBR3ad2c475d963: Escape docker output
- Patch without arc
- git checkout -b D705 && curl -L https://phabricator.wikimedia.org/D705?download=true | git apply
Diff Detail
Diff Detail
- Repository
- rGBLBR Blubber
- Branch
- master
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
The pattern you've implemented looks legit. I've commented on mostly nit things.
| docker/compiler.go | ||
|---|---|---|
| 91 | This will blowup if there's an error in NewDockerInstruction as dockerInstruction will be nil, but I guess that's cool for now since there's no real error handling in Compile. :) | |
| docker/instructions.go | ||
| 33 | From what I've seen so far in the Go sphere, it's idiomatic to drop the Get from getters. https://golang.org/doc/effective_go.html#Getters Here I think it makes more sense to simply drop the getter altogether since Arguments is an exported field. | |
| 44 | Whitespace nit. | |
| 52 | Whitespace nit. | |
| 61 | Whitespace nit. | |
Comment Actions
Changes look good and you already mentioned that gofmt enforces that single-line struct format and upstream confirms that's just the way it is.