Parse quantity units from input
AcceptedPublic
Actions

Authored by matej_suchanek on Jul 18 2017, 10:28 AM.

Details

Reviewers

Magnus

Patch without arc

git checkout -b D723 && curl -L https://phabricator.wikimedia.org/D723?download=true | git apply

Summary

1U11573 should add "1 metre"

Diff Detail

Repository

R2010 tool-quickstatements

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

matej_suchanek created this revision.Jul 18 2017, 10:28 AM

This problem isn’t introduced with this change, but shouldn’t the default unit be http://www.wikidata.org/entity/Q199 instead of 1? See T167565: Wikidata allows invalid URIs to be entered as units.

Lua and JSON serializations both output "1", so the same input is logical to me. Pywikibot and HarvestTemplates do the same. Do you have a link to a guidance which says "always provide URIs"?

Oh, I guess 1 is converted to that URI when exporting to RDF. Nevermind then.

Applied by manual edit

This revision is now accepted and ready to land.Jul 27 2017, 10:20 AM

Magnus mentioned this in R2010:3c6bc62afaea: Manually applying patch D723 by matej_suchanek.Jul 27 2017, 10:21 AM

Revision Contents
Changeset List

Path

Size

public_html/

quickstatements.php

10 lines

Diff 1908

View Options

public_html/quickstatements.php

Parse quantity units from inputAcceptedPublicActions