Page MenuHomePhabricator

Add scap3 deployment support
ClosedPublic

Authored by bd808 on Sep 1 2017, 3:53 AM.

Details

Reviewers
Niharika
thcipriani
Group Reviewers
Release-Engineering-Team
Commits
rWIEG69c4c3fe83d2: Add scap3 deployment support
Patch without arc
git checkout -b D766 && curl -L https://phabricator.wikimedia.org/D766?download=true | git apply
Summary
  • Add scap.cfg and related control files
  • Update env loading to support /etc/iegreview.ini

Bug: T129154

Test Plan

Have Release-Engineering-Team folks take a look.

Revert Plan

git revert <commit>

Diff Detail

Repository
rWIEG wikimedia-iegreview
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

bd808 created this revision.Sep 1 2017, 3:53 AM
thcipriani accepted this revision.Sep 1 2017, 3:49 PM
thcipriani added a subscriber: thcipriani.

Looks good from the scap side. IEGReview code matches what was done with scholarships, lgtm although I have no experience with the application.

One minor nit, but will not currently affect functionality.

scap/scap.cfg
4

this is the default, could be omitted.

This revision is now accepted and ready to land.Sep 1 2017, 3:49 PM
bd808 updated this revision to Diff 2018.Sep 1 2017, 4:39 PM

Drop git_deploy_dir from scap.cfg

bd808 marked an inline comment as done.Sep 1 2017, 4:39 PM
This revision was automatically updated to reflect the committed changes.