Page MenuHomePhabricator

Add MAX_ANIMATED_GIF_AREA option to Gif engine
ClosedPublic

Authored by Gilles on Sep 8 2017, 8:17 AM.

Details

Maniphest Tasks
T173580: $wgMaxAnimatedGifArea is not honored by Thumbor
Reviewers
fgiunchedi
Bawolff
Dispenser
Commits
rTHMBREXT1314e2179779: Add MAX_ANIMATED_GIF_AREA option to Gif engine
Patch without arc
git checkout -b D772 && curl -L https://phabricator.wikimedia.org/D772?download=true | git apply
Summary

Reproduces the logic of $wgMaxAnimatedGifArea in Mediawiki

Refs T173580

Diff Detail

Repository
rTHMBREXT Thumbor Plugins
Branch
master
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 2196
Build 3559: differential-jessieJenkins
Build 3558: arc lint + arc unit

Event Timeline

Gilles created this revision.Sep 8 2017, 8:17 AM
fgiunchedi added inline comments.Sep 8 2017, 8:32 AM
wikimedia_thumbor/engine/gif/gif.py
50

AFAICT in this case load will return None whereas it was returning whatever super was, worth keeping the same behavior (?)

Gilles added inline comments.Sep 8 2017, 8:44 AM
wikimedia_thumbor/engine/gif/gif.py
50

The parent isn't returning anything, that's why I got rid of the return

fgiunchedi accepted this revision.Sep 8 2017, 8:47 AM
This revision is now accepted and ready to land.Sep 8 2017, 8:47 AM
This revision was automatically updated to reflect the committed changes.