Page MenuHomePhabricator

Support go-import meta tags
ClosedPublic

Authored by mmodell on Sep 12 2017, 1:07 AM.

Details

Reviewers
dduvall
Commits
rPHEX5dba7cbec09b: Support go-import meta tags
Patch without arc
git checkout -b D776 && curl -L https://phabricator.wikimedia.org/D776?download=true | git apply
Summary

GoGetMetaRepositoryExtension is a class which adds custom handling
of diffusion requests that include ?go-get=1 in the url.

To make this work, a custom extension mechanism was added to
DiffusionRepositoryController in D775

Test Plan

see test plan in D775

Depends-on: D775

Diff Detail

Repository
rPHEX phabricator-extensions
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mmodell created this revision.Sep 12 2017, 1:07 AM

This is awesome. Thanks @20after4!

src/diffusion/GoGetMetaRepositoryExtension.php
20

I may have given you bad info about the first content parameter. Looking at GitHub's implementation, it looks like it should be the full repo URL, e.g. content="phabricator.wikimedia.org/source/blubber git $uri".

mmodell updated this revision to Diff 2053.Sep 12 2017, 8:27 PM

update the go path and make sure to use https.

mmodell marked an inline comment as done.Sep 12 2017, 8:27 PM
This revision is now accepted and ready to land.Sep 12 2017, 10:08 PM
This revision was automatically updated to reflect the committed changes.