Page MenuHomePhabricator

Provide Debian packaging files
ClosedPublic

Authored by dduvall on Sep 13 2017, 5:48 PM.

Details

Maniphest Tasks
T175609: Package Blubber
Reviewers
thcipriani
Joe
Group Reviewers
Release-Engineering-Team
Commits
rGBLBR8ff4d41552d5: Provide Debian packaging files
Patch without arc
git checkout -b D778 && curl -L https://phabricator.wikimedia.org/D778?download=true | git apply
Summary

Initial files generated by dh-make-golang have been modified.

Fixes T175609
Depends on D780, D782

Test Plan

Build the package with gbp buildpackage -us -uc.

Diff Detail

Repository
rGBLBR Blubber
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

dduvall created this revision.Sep 13 2017, 5:48 PM
Restricted Application added a reviewer: Release-Engineering-Team. · View Herald TranscriptSep 13 2017, 5:48 PM
Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript
dduvall planned changes to this revision.Sep 13 2017, 8:28 PM

This isn't going to work until D776: Support go-import meta tags is deployed and we change all the import paths to phabricator.wikimedia.org/source/blubber (without the .git).

dduvall updated this revision to Diff 2058.Sep 14 2017, 5:50 AM
dduvall edited the summary of this revision. (Show Details)
dduvall edited the test plan for this revision. (Show Details)

Rebased on D780

dduvall updated this revision to Diff 2064.Sep 14 2017, 5:20 PM
dduvall edited the summary of this revision. (Show Details)

Added D782 dependency

\o/

dduvall@dutiful:~/blubber$ gbp buildpackage -us -uc
gbp:info: Creating blubber_0.0~git20170911.0.4e5c728.orig.tar.gz from 'HEAD'
 dpkg-buildpackage -rfakeroot -us -uc -i -I
dpkg-buildpackage: info: source package blubber
dpkg-buildpackage: info: source version 0.0~git20170911.0.4e5c728-1
dpkg-buildpackage: info: source distribution unstable
dpkg-buildpackage: info: source changed by Dan Duvall <dduvall@wikimedia.org>
 dpkg-source -i -I --before-build blubber
dpkg-buildpackage: info: host architecture amd64
 fakeroot debian/rules clean
dh clean --buildsystem=golang --with=golang
   dh_testdir -O--buildsystem=golang
   dh_auto_clean -O--buildsystem=golang
   dh_autoreconf_clean -O--buildsystem=golang
   dh_clean -O--buildsystem=golang
 dpkg-source -i -I -b blubber
dpkg-source: info: using source format '3.0 (quilt)'
dpkg-source: info: building blubber using existing ./blubber_0.0~git20170911.0.4e5c728.orig.tar.gz
dpkg-source: info: building blubber in blubber_0.0~git20170911.0.4e5c728-1.debian.tar.xz
dpkg-source: info: building blubber in blubber_0.0~git20170911.0.4e5c728-1.dsc
 debian/rules build
make: 'build' is up to date.
 fakeroot debian/rules binary
dh binary --buildsystem=golang --with=golang
   dh_testdir -O--buildsystem=golang
   dh_update_autotools_config -O--buildsystem=golang
   dh_autoreconf -O--buildsystem=golang
   dh_auto_configure -O--buildsystem=golang
   dh_auto_build -O--buildsystem=golang
	go install -v -p 1 phabricator.wikimedia.org/source/blubber phabricator.wikimedia.org/source/blubber/build phabricator.wikimedia.org/source/blubber/config phabricator.wikimedia.org/source/blubber/docker
gopkg.in/yaml.v2
phabricator.wikimedia.org/source/blubber/build
phabricator.wikimedia.org/source/blubber/config
phabricator.wikimedia.org/source/blubber/docker
phabricator.wikimedia.org/source/blubber
   dh_auto_test -O--buildsystem=golang
	go test -v -p 1 phabricator.wikimedia.org/source/blubber phabricator.wikimedia.org/source/blubber/build phabricator.wikimedia.org/source/blubber/config phabricator.wikimedia.org/source/blubber/docker
?   	phabricator.wikimedia.org/source/blubber	[no test files]
=== RUN   TestRun
--- PASS: TestRun (0.00s)
=== RUN   TestRunWithInnerAndOuterArguments
--- PASS: TestRunWithInnerAndOuterArguments (0.00s)
=== RUN   TestRunAll
--- PASS: TestRunAll (0.00s)
=== RUN   TestCopy
--- PASS: TestCopy (0.00s)
=== RUN   TestCopyFrom
--- PASS: TestCopyFrom (0.00s)
=== RUN   TestEnv
--- PASS: TestEnv (0.00s)
=== RUN   TestVolume
--- PASS: TestVolume (0.00s)
PASS
ok  	phabricator.wikimedia.org/source/blubber/build	0.018s
=== RUN   TestAptConfig
--- PASS: TestAptConfig (0.00s)
=== RUN   TestAptConfigInstructions
=== RUN   TestAptConfigInstructions/PhasePrivileged
=== RUN   TestAptConfigInstructions/PhasePrivilegeDropped
=== RUN   TestAptConfigInstructions/PhasePreInstall
=== RUN   TestAptConfigInstructions/PhasePostInstall
--- PASS: TestAptConfigInstructions (0.00s)
    --- PASS: TestAptConfigInstructions/PhasePrivileged (0.00s)
    --- PASS: TestAptConfigInstructions/PhasePrivilegeDropped (0.00s)
    --- PASS: TestAptConfigInstructions/PhasePreInstall (0.00s)
    --- PASS: TestAptConfigInstructions/PhasePostInstall (0.00s)
=== RUN   TestArtifactsConfig
--- PASS: TestArtifactsConfig (0.00s)
=== RUN   TestArtifactsConfigInstructions
=== RUN   TestArtifactsConfigInstructions/PhasePrivileged
=== RUN   TestArtifactsConfigInstructions/PhasePrivilegeDropped
=== RUN   TestArtifactsConfigInstructions/PhasePreInstall
=== RUN   TestArtifactsConfigInstructions/PhasePostInstall
--- PASS: TestArtifactsConfigInstructions (0.00s)
    --- PASS: TestArtifactsConfigInstructions/PhasePrivileged (0.00s)
    --- PASS: TestArtifactsConfigInstructions/PhasePrivilegeDropped (0.00s)
    --- PASS: TestArtifactsConfigInstructions/PhasePreInstall (0.00s)
    --- PASS: TestArtifactsConfigInstructions/PhasePostInstall (0.00s)
=== RUN   TestCommonConfig
--- PASS: TestCommonConfig (0.00s)
=== RUN   TestFlagOverwrite
--- PASS: TestFlagOverwrite (0.00s)
=== RUN   TestNodeConfig
--- PASS: TestNodeConfig (0.00s)
=== RUN   TestNodeConfigInstructionsNoDependencies
=== RUN   TestNodeConfigInstructionsNoDependencies/PhasePrivileged
=== RUN   TestNodeConfigInstructionsNoDependencies/PhasePrivilegeDropped
=== RUN   TestNodeConfigInstructionsNoDependencies/PhasePreInstall
=== RUN   TestNodeConfigInstructionsNoDependencies/PhasePostInstall
--- PASS: TestNodeConfigInstructionsNoDependencies (0.00s)
    --- PASS: TestNodeConfigInstructionsNoDependencies/PhasePrivileged (0.00s)
    --- PASS: TestNodeConfigInstructionsNoDependencies/PhasePrivilegeDropped (0.00s)
    --- PASS: TestNodeConfigInstructionsNoDependencies/PhasePreInstall (0.00s)
    --- PASS: TestNodeConfigInstructionsNoDependencies/PhasePostInstall (0.00s)
=== RUN   TestNodeConfigInstructionsNonProduction
=== RUN   TestNodeConfigInstructionsNonProduction/PhasePrivileged
=== RUN   TestNodeConfigInstructionsNonProduction/PhasePrivilegeDropped
=== RUN   TestNodeConfigInstructionsNonProduction/PhasePreInstall
=== RUN   TestNodeConfigInstructionsNonProduction/PhasePostInstall
--- PASS: TestNodeConfigInstructionsNonProduction (0.00s)
    --- PASS: TestNodeConfigInstructionsNonProduction/PhasePrivileged (0.00s)
    --- PASS: TestNodeConfigInstructionsNonProduction/PhasePrivilegeDropped (0.00s)
    --- PASS: TestNodeConfigInstructionsNonProduction/PhasePreInstall (0.00s)
    --- PASS: TestNodeConfigInstructionsNonProduction/PhasePostInstall (0.00s)
=== RUN   TestNodeConfigInstructionsProduction
=== RUN   TestNodeConfigInstructionsProduction/PhasePrivileged
=== RUN   TestNodeConfigInstructionsProduction/PhasePrivilegeDropped
=== RUN   TestNodeConfigInstructionsProduction/PhasePreInstall
=== RUN   TestNodeConfigInstructionsProduction/PhasePostInstall
--- PASS: TestNodeConfigInstructionsProduction (0.00s)
    --- PASS: TestNodeConfigInstructionsProduction/PhasePrivileged (0.00s)
    --- PASS: TestNodeConfigInstructionsProduction/PhasePrivilegeDropped (0.00s)
    --- PASS: TestNodeConfigInstructionsProduction/PhasePreInstall (0.00s)
    --- PASS: TestNodeConfigInstructionsProduction/PhasePostInstall (0.00s)
=== RUN   TestNodeConfigInstructionsEnvironmentOnly
=== RUN   TestNodeConfigInstructionsEnvironmentOnly/PhasePrivileged
=== RUN   TestNodeConfigInstructionsEnvironmentOnly/PhasePrivilegeDropped
=== RUN   TestNodeConfigInstructionsEnvironmentOnly/PhasePreInstall
=== RUN   TestNodeConfigInstructionsEnvironmentOnly/PhasePostInstall
--- PASS: TestNodeConfigInstructionsEnvironmentOnly (0.00s)
    --- PASS: TestNodeConfigInstructionsEnvironmentOnly/PhasePrivileged (0.00s)
    --- PASS: TestNodeConfigInstructionsEnvironmentOnly/PhasePrivilegeDropped (0.00s)
    --- PASS: TestNodeConfigInstructionsEnvironmentOnly/PhasePreInstall (0.00s)
    --- PASS: TestNodeConfigInstructionsEnvironmentOnly/PhasePostInstall (0.00s)
=== RUN   TestRunsConfig
--- PASS: TestRunsConfig (0.00s)
=== RUN   TestRunsHomeWithUser
--- PASS: TestRunsHomeWithUser (0.00s)
=== RUN   TestRunsHomeWithoutUser
--- PASS: TestRunsHomeWithoutUser (0.00s)
=== RUN   TestRunsConfigInstructions
=== RUN   TestRunsConfigInstructions/PhasePrivileged
=== RUN   TestRunsConfigInstructions/PhasePrivilegeDropped
=== RUN   TestRunsConfigInstructions/PhasePrivilegeDropped/with_empty_Environment
=== RUN   TestRunsConfigInstructions/PhasePreInstall
=== RUN   TestRunsConfigInstructions/PhasePostInstall
--- PASS: TestRunsConfigInstructions (0.00s)
    --- PASS: TestRunsConfigInstructions/PhasePrivileged (0.00s)
    --- PASS: TestRunsConfigInstructions/PhasePrivilegeDropped (0.00s)
        --- PASS: TestRunsConfigInstructions/PhasePrivilegeDropped/with_empty_Environment (0.00s)
    --- PASS: TestRunsConfigInstructions/PhasePreInstall (0.00s)
    --- PASS: TestRunsConfigInstructions/PhasePostInstall (0.00s)
=== RUN   TestVariantConfig
--- PASS: TestVariantConfig (0.00s)
=== RUN   TestVariantDependencies
--- PASS: TestVariantDependencies (0.00s)
=== RUN   TestVariantLoops
--- PASS: TestVariantLoops (0.00s)
=== RUN   TestMultiLevelIncludes
--- PASS: TestMultiLevelIncludes (0.00s)
=== RUN   TestVariantConfigInstructions
=== RUN   TestVariantConfigInstructions/PhaseInstall
=== RUN   TestVariantConfigInstructions/PhaseInstall/copies
=== RUN   TestVariantConfigInstructions/PhaseInstall/shared_volume
=== RUN   TestVariantConfigInstructions/PhaseInstall/standard_source_copy
=== RUN   TestVariantConfigInstructions/PhasePostInstall
=== RUN   TestVariantConfigInstructions/PhasePostInstall/for_copies_and_artifacts
=== RUN   TestVariantConfigInstructions/PhasePostInstall/for_just_artifacts
--- PASS: TestVariantConfigInstructions (0.00s)
    --- PASS: TestVariantConfigInstructions/PhaseInstall (0.00s)
        --- PASS: TestVariantConfigInstructions/PhaseInstall/copies (0.00s)
        --- PASS: TestVariantConfigInstructions/PhaseInstall/shared_volume (0.00s)
        --- PASS: TestVariantConfigInstructions/PhaseInstall/standard_source_copy (0.00s)
    --- PASS: TestVariantConfigInstructions/PhasePostInstall (0.00s)
        --- PASS: TestVariantConfigInstructions/PhasePostInstall/for_copies_and_artifacts (0.00s)
        --- PASS: TestVariantConfigInstructions/PhasePostInstall/for_just_artifacts (0.00s)
PASS
ok  	phabricator.wikimedia.org/source/blubber/config	0.028s
=== RUN   TestSingleStageHasNoName
--- PASS: TestSingleStageHasNoName (0.00s)
=== RUN   TestMultiStageIncludesStageNames
--- PASS: TestMultiStageIncludesStageNames (0.00s)
=== RUN   TestMultipleArtifactsFromSameStage
--- PASS: TestMultipleArtifactsFromSameStage (0.00s)
=== RUN   TestRun
--- PASS: TestRun (0.00s)
=== RUN   TestRunAll
--- PASS: TestRunAll (0.00s)
=== RUN   TestCopy
--- PASS: TestCopy (0.00s)
=== RUN   TestCopyFrom
--- PASS: TestCopyFrom (0.00s)
=== RUN   TestEnv
--- PASS: TestEnv (0.00s)
=== RUN   TestVolume
--- PASS: TestVolume (0.00s)
=== RUN   TestEscapeRun
--- PASS: TestEscapeRun (0.00s)
=== RUN   TestEscapeCopy
--- PASS: TestEscapeCopy (0.00s)
=== RUN   TestEscapeEnv
--- PASS: TestEscapeEnv (0.00s)
PASS
ok  	phabricator.wikimedia.org/source/blubber/docker	0.018s
   create-stamp debian/debhelper-build-stamp
   dh_testroot -O--buildsystem=golang
   dh_prep -O--buildsystem=golang
   dh_auto_install -O--buildsystem=golang
	mkdir -p /home/dduvall/blubber/debian/blubber/usr
	cp -r bin /home/dduvall/blubber/debian/blubber/usr
	mkdir -p /home/dduvall/blubber/debian/blubber/usr/share/gocode/src/phabricator.wikimedia.org/source/blubber
	cp -r -T src/phabricator.wikimedia.org/source/blubber /home/dduvall/blubber/debian/blubber/usr/share/gocode/src/phabricator.wikimedia.org/source/blubber
   dh_installdocs -O--buildsystem=golang
   dh_installchangelogs -O--buildsystem=golang
   dh_perl -O--buildsystem=golang
   dh_link -O--buildsystem=golang
   dh_strip_nondeterminism -O--buildsystem=golang
   dh_compress -O--buildsystem=golang
   dh_fixperms -O--buildsystem=golang
   dh_strip -O--buildsystem=golang
   dh_makeshlibs -O--buildsystem=golang
   dh_shlibdeps -O--buildsystem=golang
   dh_installdeb -O--buildsystem=golang
   dh_golang -O--buildsystem=golang
   dh_gencontrol -O--buildsystem=golang
dpkg-gencontrol: warning: Depends field of package blubber: unknown substitution variable ${shlibs:Depends}
   dh_md5sums -O--buildsystem=golang
   dh_builddeb -u-Zxz -O--buildsystem=golang
dpkg-deb: building package 'blubber' in '../blubber_0.0~git20170911.0.4e5c728-1_amd64.deb'.
 dpkg-genbuildinfo
 dpkg-genchanges  >../blubber_0.0~git20170911.0.4e5c728-1_amd64.changes
dpkg-genchanges: info: including full source code in upload
 dpkg-source -i -I --after-build blubber
dpkg-buildpackage: info: full upload (original source is included)
Now running lintian...
W: blubber source: space-in-std-shortname-in-dep5-copyright apache 2.0 (paragraph at line 3)
W: blubber: new-package-should-close-itp-bug
E: blubber: description-starts-with-package-name
W: blubber: binary-without-manpage usr/bin/blubber
Finished running lintian.
thcipriani accepted this revision.Sep 14 2017, 7:17 PM

Able to build, new inline lintian nitpicks.

Also: W: blubber: binary-without-manpage usr/bin/blubber

debian/control
21

E: blubber: description-starts-with-package-name

debian/copyright
5

W: blubber source: space-in-std-shortname-in-dep5-copyright apache 2.0 (paragraph at line 3)
License: Apache-2.0

This revision is now accepted and ready to land.Sep 14 2017, 7:17 PM
dduvall updated this revision to Diff 2067.Sep 14 2017, 7:35 PM

Addressed license file and description nits. Skipping manpage for now

dduvall updated this revision to Diff 2068.Sep 14 2017, 7:42 PM

Fixed description-synopsis-starts-with-article and extended-description-contains-empty-paragraph lintian warnings

This revision was automatically updated to reflect the committed changes.