Page MenuHomePhabricator

Add "additive" field to metric definitions
ClosedPublic

Authored by fdans on Sep 14 2017, 5:32 PM.

Details

Maniphest Tasks
T170937: Wikistats2 bugs (3/4) - Data issues
Reviewers
Milimetric
Commits
rWIKISTATSd66b7ea235b9: Add "additive" field to metric definitions
Patch without arc
git checkout -b D783 && curl -L https://phabricator.wikimedia.org/D783?download=true | git apply
Summary

Some time ago I implemented a change so that metrics that were declared additive would show the year total in the dashboard card, and for those which aren't , the monthly average. Even though this was implemented in the dashboard metrics, i never added the kfield to the config

Ref T170937

Diff Detail

Repository
rWIKISTATS analytics-wikistats-new
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

fdans created this revision.Sep 14 2017, 5:32 PM
Milimetric accepted this revision.Sep 16 2017, 11:09 PM
This revision is now accepted and ready to land.Sep 16 2017, 11:09 PM
This revision was automatically updated to reflect the committed changes.