Page MenuHomePhabricator

Replace ImageMagick -auto-orient with manual logic
ClosedPublic

Authored by Gilles on Sep 19 2017, 12:30 PM.

Details

Maniphest Tasks
T173804: Rotation parameters from EXIF fail in Mediawiki
Reviewers
fgiunchedi
TheDJ
Commits
rTHMBREXTf2b65768d81d: Replace ImageMagick -auto-orient with manual logic
Patch without arc
git checkout -b D789 && curl -L https://phabricator.wikimedia.org/D789?download=true | git apply
Summary

Refs T173804

Diff Detail

Repository
rTHMBREXT Thumbor Plugins
Branch
master
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 2258
Build 3653: differential-jessieJenkins
Build 3652: arc lint + arc unit

Event Timeline

Gilles created this revision.Sep 19 2017, 12:30 PM
fgiunchedi added inline comments.Sep 19 2017, 1:38 PM
tests/integration/test_types.py
24

I'm assuming these are testing orientation values, it'd be good to add a comment

Gilles updated this revision to Diff 2086.Sep 19 2017, 1:46 PM

Move tests

Gilles marked an inline comment as done.Sep 19 2017, 1:46 PM
Gilles added inline comments.
tests/integration/test_types.py
24

I've moved them to the more appropriate test_exif_orientation in test_exif.py

This revision is now accepted and ready to land.Sep 20 2017, 9:29 AM
This revision was automatically updated to reflect the committed changes.
Gilles marked an inline comment as done.