Added SQL_CALC_FOUND_ROWS and pagination information
Bug: T116259
Differential D790
Fix for pagination button on scores page Nehajha on Sep 20 2017, 2:26 PM. Authored by
Details
Added SQL_CALC_FOUND_ROWS and pagination information Bug: T116259
Diff Detail
Event TimelineComment Actions From what I have gathered so far, there was no pagination information for the aggregated scores page. I have tested this patch for some 70 proposals. Please let me know if there are any mistakes. Thanks Comment Actions Build has FAILED Link to build: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/723/ Comment Actions
You need to make sure the build passes. Comment Actions Build has FAILED Link to build: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/745/ Comment Actions I think I need to combine these three revisions. Only then the build will pass. Could you please tell me how to combine the three revisions. Comment Actions I didn't have in data in my app setup so I added a new campaign but I couldn't access it. I got the following error - Details Type: Twig_Error_Runtime Message: An exception has been thrown during the rendering of a template ("Array to string conversion") in "proposals/queue.html" at line 27. File: /vagrant/srv/iegreview/vendor/twig/twig/lib/Twig/Template.php Line: 178 Trace #0 /vagrant/srv/iegreview/vendor/twig/twig/lib/Twig/Environment.php(332) : eval()'d code(190): Twig_Template->displayBlock('content', Array, Array) #1 /vagrant/srv/iegreview/vendor/twig/twig/lib/Twig/Template.php(340): __TwigTemplate_841cfb4224242ce4ee5c683da6ab47c7c89cdb691dd41651083e81213fdcc5a5->doDisplay(Array, Array) #2 /vagrant/srv/iegreview/vendor/twig/twig/lib/Twig/Template.php(314): Twig_Template->displayWithErrorHandling(Array, Array) #3 /vagrant/srv/iegreview/vendor/twig/twig/lib/Twig/Environment.php(332) : eval()'d code(25): Twig_Template->display(Array, Array) #4 /vagrant/srv/iegreview/vendor/twig/twig/lib/Twig/Template.php(340): __TwigTemplate_c71bc6dac1074470a9ac337606eb7a61bfacdf3ab9c787a9bd5d5658f00219ba->doDisplay(Array, Array) #5 /vagrant/srv/iegreview/vendor/twig/twig/lib/Twig/Template.php(314): Twig_Template->displayWithErrorHandling(Array, Array) #6 /vagrant/srv/iegreview/vendor/twig/twig/lib/Twig/Environment.php(332) : eval()'d code(30): Twig_Template->display(Array, Array) #7 /vagrant/srv/iegreview/vendor/twig/twig/lib/Twig/Template.php(340): __TwigTemplate_f1fdeffb279d706541df9830e749b0513d0d502c57e06132281b603d2dc5e5c4->doDisplay(Array, Array) #8 /vagrant/srv/iegreview/vendor/twig/twig/lib/Twig/Template.php(314): Twig_Template->displayWithErrorHandling(Array, Array) #9 /vagrant/srv/iegreview/vendor/twig/twig/lib/Twig/Template.php(325): Twig_Template->display(Array) #10 /vagrant/srv/iegreview/vendor/slim/views/Slim/Views/Twig.php(91): Twig_Template->render(Array) #11 /vagrant/srv/iegreview/vendor/slim/slim/Slim/View.php(255): Slim\Views\Twig->render('proposals/queue...', NULL) #12 /vagrant/srv/iegreview/vendor/slim/slim/Slim/View.php(243): Slim\View->fetch('proposals/queue...', NULL) #13 /vagrant/srv/iegreview/vendor/slim/slim/Slim/Slim.php(757): Slim\View->display('proposals/queue...') #14 [internal function]: Slim\Slim->render('proposals/queue...', Array) #15 /vagrant/srv/iegreview/src/Controller.php(97): call_user_func_array(Array, Array) #16 /vagrant/srv/iegreview/src/Controllers/Proposals/Queue.php(79): Wikimedia\IEGReview\Controller->__call('render', Array) #17 /vagrant/srv/iegreview/src/Controllers/Proposals/Queue.php(79): Wikimedia\IEGReview\Controllers\Proposals\Queue->render('proposals/queue...', Array) #18 [internal function]: Wikimedia\IEGReview\Controllers\Proposals\Queue->handleGet('1') #19 /vagrant/srv/iegreview/src/Controller.php(88): call_user_func_array(Array, Array) #20 /vagrant/srv/iegreview/src/App.php(536): Wikimedia\IEGReview\Controller->__invoke('1') #21 [internal function]: Wikimedia\IEGReview\App->Wikimedia\IEGReview\{closure}('1') #22 /vagrant/srv/iegreview/vendor/slim/slim/Slim/Route.php(462): call_user_func_array(Object(Closure), Array) #23 /vagrant/srv/iegreview/vendor/slim/slim/Slim/Slim.php(1326): Slim\Route->dispatch() #24 /vagrant/srv/iegreview/vendor/slim/slim/Slim/Middleware/Flash.php(85): Slim\Slim->call() #25 /vagrant/srv/iegreview/vendor/slim/slim/Slim/Middleware/MethodOverride.php(92): Slim\Middleware\Flash->call() #26 /vagrant/srv/iegreview/src/HeaderMiddleware.php(65): Slim\Middleware\MethodOverride->call() #27 /vagrant/srv/iegreview/src/CsrfMiddleware.php(66): Wikimedia\IEGReview\HeaderMiddleware->call() #28 /vagrant/srv/iegreview/vendor/slim/slim/Slim/Middleware/PrettyExceptions.php(67): Wikimedia\IEGReview\CsrfMiddleware->call() #29 /vagrant/srv/iegreview/vendor/slim/slim/Slim/Slim.php(1271): Slim\Middleware\PrettyExceptions->call() #30 /vagrant/srv/iegreview/src/App.php(134): Slim\Slim->run() #31 /vagrant/srv/iegreview/public/index.php(47): Wikimedia\IEGReview\App->run() #32 {main} This was even before I could test this patch so the patch has nothing to do with it. I'm baffled because it's a fresh install and clean git history. I'll try to fix this later today/tomorrow and test your patch after that. Adding @bd808 as a reviewer too. Comment Actions Very close to correct, but see inline comments for needed corrections.
Comment Actions Build has FAILED Link to build: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/932/ Comment Actions I can't seem to merge this patch. The error was fatal: remote error: Upload denied for project 'wikimedia/iegreview' I did provide the right username and password for Gerrit. Probably, I do not have upload permissions. Comment Actions Darn. I somehow didn't think of that. You are of course right that you do not have push rights to this repo. I had trouble landing it myself. This seems at least in part due to MediaWiki-Vagrant cloning the repo from the gerrit mirror. After running git remote -v set-url origin ssh://vcs@git-ssh.wikimedia.org/diffusion/WIEG/iegreview.git to change that to point to the Phab repo instead I was able to land the patch. |