Page MenuHomePhabricator

EditEngine: 'Duplicate Form' action to create new forms from existing config.
ClosedPublic

Authored by mmodell on Oct 10 2017, 9:52 PM.

Details

Maniphest Tasks
T93499: Add support for task types
Reviewers
Paladox
Commits
rPHAB893664bd44b8: EditEngine: 'Duplicate Form' action to create new forms from existing config.
Patch without arc
git checkout -b D803 && curl -L https://phabricator.wikimedia.org/D803?download=true | git apply
Summary

The editengine form view gets a new action which duplicates all of the settings
for a given form so that several forms can be created with the same field order,
visibility and default values.

This also modifies the behavior of editengine fields so that the default visibility
of a given field is controlled by the field's implementation. Now customfields are
default hidden and built-in fields are default visible.

Test Plan

Tested locally by duplicating some forms, editing said forms, etc.

Revert Plan

Can just revert the commit, nothing too fancy here.

Diff Detail

Repository
rPHAB Phabricator
Branch
wmf/stable
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 2314
Build 3763: differential-jessieJenkins
Build 3762: arc lint + arc unit

Event Timeline

mmodell created this revision.Oct 10 2017, 9:52 PM
Paladox accepted this revision.Oct 10 2017, 10:00 PM

Failure unrelated.

This revision is now accepted and ready to land.Oct 10 2017, 10:00 PM
mmodell closed this revision.Oct 16 2017, 2:40 PM