Page MenuHomePhabricator

Remove support for DOLOGMSGNOLOG environment variable
ClosedPublic

Authored by demon on Oct 16 2017, 9:15 PM.
Referenced Files
Unknown Object (File)
Aug 16 2022, 5:36 AM
Unknown Object (File)
Jun 25 2022, 8:05 PM
Subscribers

Details

Reviewers
mmodell
thcipriani
Group Reviewers
Release-Engineering-Team
Commits
rMSCA479b707f963d: Remove support for DOLOGMSGNOLOG environment variable
Patch without arc
git checkout -b D822 && curl -L https://phabricator.wikimedia.org/D822?download=true | git apply
Summary

It's a weird anti-pattern to how we handle options and such to Scap. A command line flag makes this much clearer and less likely for people to forget exists.

Resolves T68049

Diff Detail

Repository
rMSCA Scap
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Restricted Application added a reviewer: Release-Engineering-Team. · View Herald Transcript
Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript
  • Still support environment variable as a fallback, with a warning
This revision is now accepted and ready to land.Oct 19 2017, 9:20 PM
This revision was automatically updated to reflect the committed changes.