This hides the LDAP login form but provides a button to toggle it. Here is what it looks like:
Fixes T963
Details
Details
- Maniphest Tasks
- T862: Redesign Phabricator login page: LDAP login too prominent; position of MediaWiki SUL login not prominent enough
T963: Make the phabricator OAuth login UI more prominent - Reviewers
Nemo_bis Qgil Aklapper • MZMcBride • chasemp Paladox - Patch without arc
- git checkout -b D831 && curl -L https://phabricator.wikimedia.org/D831?download=true | git apply
Tested locally on my phabricator dev. instance. Tried login page, toggled the ldap form, etc.
Diff Detail
Diff Detail
- Repository
- rPHAB Phabricator
- Branch
- wmf/stable
- Lint
Lint Passed - Unit
Tests Passed
Event Timeline
Comment Actions
Build has FAILED
Link to build: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/783/
See console output for more information: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/783/console
| webroot/rsrc/css/application/auth/auth.css | ||
|---|---|---|
| 59 | Is there a way to make this only apply when JavaScript is enabled? Otherwise the main log in form will be rendered inaccessible. Alternate: The outcome looks good, and if that's what it was already, I wouldn't have known better. But compared to the current state, it seems the main difference from this commit would be adding the wording of "Wikitech/Gerrit" in close proximity to the LDAP form. Perhaps a solution could be to leave the form as-is, but improve the label of this heading? Example:  | |
| webroot/rsrc/css/application/auth/auth.css | ||
|---|---|---|
| 59 |
I will see what I can come up with...
One of the main purposes is to De-emphasize the LDAP form, so changing the wording would be an improvement but I don't think it would resolve T963 | |
Comment Actions
Build has FAILED
Link to build: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/784/
See console output for more information: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/784/console