Page MenuHomePhabricator

Don't lie when sync-wikiversions actually failed
ClosedPublic

Authored by demon on Oct 23 2017, 8:28 PM.

Details

Reviewers
mmodell
Group Reviewers
Release-Engineering-Team
Commits
rMSCA5d984f685a69: Don't lie when sync-wikiversions actually failed
Patch without arc
git checkout -b D832 && curl -L https://phabricator.wikimedia.org/D832?download=true | git apply
Summary

Similar logic from scap sync itself, actually warn to the operator that there's been failures. Also don't spread that lie to IRC when we had absolutely no successful syncs.

Should solve T78024

Diff Detail

Repository
rMSCA Scap
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

demon created this revision.Oct 23 2017, 8:28 PM
Restricted Application added a reviewer: mmodell. · View Herald TranscriptOct 23 2017, 8:28 PM
Restricted Application added a reviewer: Release-Engineering-Team. · View Herald Transcript
Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript
demon updated this revision to Diff 2207.Oct 23 2017, 10:44 PM

Rebased

This revision is now accepted and ready to land.Oct 24 2017, 5:51 AM
This revision was automatically updated to reflect the committed changes.