Page MenuHomePhabricator

Stop using predefined built-in functions and such in scap code
ClosedPublic

Authored by demon on Oct 23 2017, 9:56 PM.

Details

Reviewers
mmodell
Group Reviewers
Release-Engineering-Team
Commits
rMSCA93e9b27e809f: Stop using predefined built-in functions and such in scap code
Patch without arc
git checkout -b D833 && curl -L https://phabricator.wikimedia.org/D833?download=true | git apply
Summary

It's considered bad form, and when refactoring for this change it was
pretty clear why: minor changes like renaming a variable can lead to
subtle breakages. Additionally, it makes things easier to grep for when
you're doing refactors and other fun stuff

Diff Detail

Event Timeline

demon created this revision.Oct 23 2017, 9:56 PM
Restricted Application added a reviewer: mmodell. · View Herald TranscriptOct 23 2017, 9:56 PM
Restricted Application added a reviewer: Release-Engineering-Team. · View Herald Transcript
Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript
demon updated this revision to Diff 2203.Oct 23 2017, 9:58 PM
  • Fix line too long
demon updated this revision to Diff 2204.Oct 23 2017, 10:05 PM
  • Fix doc example
mmodell accepted this revision.Oct 23 2017, 10:34 PM

Good idea.

This revision is now accepted and ready to land.Oct 23 2017, 10:34 PM
demon updated this revision to Diff 2205.Oct 23 2017, 10:40 PM

Rebased

This revision was automatically updated to reflect the committed changes.