Use backported ConfigParser from 3.2+
ClosedPublic

Authored by demon on Oct 24 2017, 3:09 PM.

Details

Reviewers
mmodell
Group Reviewers
Release-Engineering-Team
Commits
rMSCA7d4d202c234e: Use backported ConfigParser from 3.2+
Patch without arc
git checkout -b D838 && curl -L https://phabricator.wikimedia.org/D838?download=true | git apply
Summary

It's already nicely packaged, and allows us to write portable code

Test Plan

Tests all still worked for me

Diff Detail

Repository
rMSCA Scap
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
demon created this revision.Oct 24 2017, 3:09 PM
Restricted Application added a reviewer: mmodell. · View Herald TranscriptOct 24 2017, 3:09 PM
Restricted Application added a reviewer: Release-Engineering-Team. · View Herald Transcript
Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript

So how is this different? just the way it's imported and instantiated changes?

mmodell accepted this revision as: mmodell.Oct 27 2017, 12:26 PM

Hesitantly accepted without testing it.

This revision is now accepted and ready to land.Oct 27 2017, 12:26 PM
demon added a comment.Oct 27 2017, 2:27 PM

AIUI, Python 2 has:

ConfigParser.ConfigParser

Python 3:

configparser.ConfigParser

The latter was backported to Python 2. While it's functionally identical, from reading around it sounds like this helps us future-proof ourselves. Maybe it's pointless tho.

This revision was automatically updated to reflect the committed changes.