Improve test coverage
ClosedPublic

Authored by mmodell on Oct 25 2017, 11:09 AM.

Details

Reviewers
demon
Group Reviewers
Release-Engineering-Team
Commits
rMSCAae6a8b5a2497: Improve test coverage
Patch without arc
git checkout -b D843 && curl -L https://phabricator.wikimedia.org/D843?download=true | git apply
Summary

Adds tests for some of scap.git and a test for
utils.cpus_for_jobs

Test Plan

ran nosetests, saw better coverage

Diff Detail

Repository
rMSCA Scap
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mmodell created this revision.Oct 25 2017, 11:09 AM
Restricted Application added a reviewer: Release-Engineering-Team. · View Herald TranscriptOct 25 2017, 11:09 AM
Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript
demon updated this revision to Diff 2232.Oct 25 2017, 7:08 PM
  • Rebased against master
mmodell updated this revision to Diff 2238.Oct 27 2017, 12:33 PM

fix failing test by passing the tempdir to update_server_info

@demon: This should be ready to land, tests are passing.

demon accepted this revision.Oct 27 2017, 6:53 PM
This revision is now accepted and ready to land.Oct 27 2017, 6:53 PM
This revision was automatically updated to reflect the committed changes.