Require git >= 2.11 in debian package
AbandonedPublic

Authored by mmodell on Oct 25 2017, 11:10 AM.

Details

Reviewers
thcipriani
demon
Group Reviewers
Release-Engineering-Team
Patch without arc
git checkout -b D844 && curl -L https://phabricator.wikimedia.org/D844?download=true | git apply
Summary

2.11 is required for the --jobs argument to several git commands,
as well as --reference.

Test Plan

untested, need to build a new .deb to test this

Diff Detail

Repository
rMSCA Scap
Branch
master
Lint
No Linters Available
Unit
Unit Tests OK
Build Status
Buildable 2419
Build 3962: docker-diffsJenkins
Build 3961: differential-jessieJenkins
Build 3960: arc lint + arc unit
mmodell created this revision.Oct 25 2017, 11:10 AM
Restricted Application added a reviewer: Release-Engineering-Team. · View Herald TranscriptOct 25 2017, 11:10 AM
Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript

will this work if you use a newer git version? IE on stretch?

demon added a comment.Oct 25 2017, 2:40 PM
In D844#16748, @Paladox wrote:

will this work if you use a newer git version? IE on stretch?

Yes. The point is we need a git version that is at least 2.11. If you have a higher version that's fine.

demon added a comment.Oct 25 2017, 2:43 PM

As I said on IRC, we need to make sure all scap targets have 2.11+ on them. As we saw on beta, not everything got upgraded. In production if we've got systems still on Trusty that could be problematic.

Silver, for example, is on 1.9.1 :(

greg added a subscriber: greg.Oct 25 2017, 9:43 PM
In D844#16752, @demon wrote:

Silver, for example, is on 1.9.1 :(

Because Trusty, I presume: https://wikitech.wikimedia.org/wiki/Wikitech

greg added a comment.Oct 25 2017, 9:57 PM

(which you said, in your previous sentence. so much for reading comprehension during 1:1s)

T179353: Scap: Standardize git version should resolve whether or not this can merge.

I've added a version check in D866: Use sh library to wrap git commands. to make --jobs conditional.

demon added a comment.Nov 15 2017, 5:16 PM

Maybe we should just abandon this since we're going the "detect version and fail gracefully" route?

In D844#17543, @demon wrote:

Maybe we should just abandon this since we're going the "detect version and fail gracefully" route?

+1

mmodell abandoned this revision.Nov 15 2017, 7:29 PM