Scap bin: Provide a sane initial docblock with license and such
ClosedPublic

Authored by demon on Oct 25 2017, 6:00 PM.

Details

Reviewers
mmodell
hashar
Group Reviewers
Release-Engineering-Team
Commits
rMSCA6919f06a5909: Scap bin: Provide a sane initial docblock with license and such
Patch without arc
git checkout -b D846 && curl -L https://phabricator.wikimedia.org/D846?download=true | git apply
Summary

Also SHOUT IN CONSTANTS while we're here

Diff Detail

Repository
rMSCA Scap
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
demon created this revision.Oct 25 2017, 6:00 PM
Restricted Application added a reviewer: mmodell. · View Herald TranscriptOct 25 2017, 6:00 PM
Restricted Application added a reviewer: Release-Engineering-Team. · View Herald Transcript
Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript
demon added inline comments.Oct 25 2017, 6:03 PM
bin/scap
32

Should this also become import scap.cli as cli like we do elsewhere, or is there some oddity here I'm missing?

hashar accepted this revision.Oct 27 2017, 7:18 AM
hashar added a subscriber: hashar.
hashar added inline comments.
bin/scap
32

They should be strictly equivalent. scap is imported first, then scap.cli and finally scap.cli is bound to the local cli.

# import x as y , used for scap submodules imports
$ git grep '^import .* as '|wc -l
      62

# from x import y, used mostly for non scap modules:
$ git grep '^from .*import'|wc -l
      73

Really, I dont think it matters :-}

This revision is now accepted and ready to land.Oct 27 2017, 7:18 AM
This revision was automatically updated to reflect the committed changes.