Clean up broad exceptions: Exception -> StandardError
ClosedPublic

Authored by demon on Oct 25 2017, 7:01 PM.

Details

Reviewers
mmodell
Group Reviewers
Release-Engineering-Team
Commits
rMSCA8994ad33c040: Clean up broad exceptions: Exception -> StandardError
Patch without arc
git checkout -b D848 && curl -L https://phabricator.wikimedia.org/D848?download=true | git apply
Summary

The errors outside of StandardError aren't things we actually want to catch and process like a failure. StopIteration isn't really an error condition and we can handle Warning classes nicer.

Also handle a few other pylint warnings while I was in scap/plugins/*

Diff Detail

Repository
rMSCA Scap
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
demon created this revision.Oct 25 2017, 7:01 PM
Restricted Application added a reviewer: mmodell. · View Herald TranscriptOct 25 2017, 7:01 PM
Restricted Application added a reviewer: Release-Engineering-Team. · View Herald Transcript
Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript
demon edited the summary of this revision. (Show Details)Oct 25 2017, 7:02 PM
mmodell accepted this revision.Oct 27 2017, 12:27 PM
This revision is now accepted and ready to land.Oct 27 2017, 12:27 PM
This revision was automatically updated to reflect the committed changes.