Differential D853

Stop using raw_input for python3 compat
ClosedPublic
Actions

Authored by demon on Oct 27 2017, 5:15 PM.

Tags

Subscribers

Details

Reviewers

Group Reviewers

Release-Engineering-Team

Commits

rMSCA53ea6b8de34e: Stop using raw_input for python3 compat

Patch without arc

git checkout -b D853 && curl -L https://phabricator.wikimedia.org/D853?download=true | git apply

Summary

Prefix input from builtins as _input() so it's easy to find after we move to py3

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

demon created this revision.Oct 27 2017, 5:15 PM

Restricted Application added a reviewer: mmodell. · View Herald TranscriptOct 27 2017, 5:15 PM

Restricted Application added a reviewer: Release-Engineering-Team. · View Herald Transcript

Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript

Build has FAILED

Link to build: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/814/
See console output for more information: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/814/console

Harbormaster failed remote builds in B2441: Diff 2247!Oct 27 2017, 5:16 PM

Build has FAILED

Link to build: https://integration.wikimedia.org/ci/job/differential-docker-test/316/
See console output for more information: https://integration.wikimedia.org/ci/job/differential-docker-test/316/console

why not do this:

from six.moves import input

mmodell added inline comments.Oct 27 2017, 5:57 PM

scap/utils.py
35	in python 2, the `input` function does not do what we want. It evaluates whatever you type as if you ran `eval(raw_input(...))` ... in python 3, input behaves sanely and the `eval` behavior is gone. The sane thing to do is to use six.

mmodell requested changes to this revision.Oct 27 2017, 5:58 PM

This revision now requires changes to proceed.Oct 27 2017, 5:58 PM

demon added inline comments.Oct 27 2017, 6:25 PM

scap/utils.py
35	Was following a different guide. Will amend.

Swap builtins.input for six.moves.input

demon marked 2 inline comments as done.Oct 27 2017, 6:29 PM

Build has FAILED

Link to build: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/815/
See console output for more information: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/815/console

Harbormaster failed remote builds in B2443: Diff 2249!Oct 27 2017, 6:29 PM

Build has FAILED

Link to build: https://integration.wikimedia.org/ci/job/differential-docker-test/317/
See console output for more information: https://integration.wikimedia.org/ci/job/differential-docker-test/317/console

demon added a parent revision: D852: Stop using xrange() for python 3 compat.Oct 27 2017, 6:34 PM

mmodell accepted this revision.Oct 27 2017, 6:57 PM

This revision is now accepted and ready to land.Oct 27 2017, 6:57 PM

Rebased

Harbormaster completed remote builds in B2451: Diff 2257.Oct 27 2017, 7:04 PM

Closed by commit rMSCA53ea6b8de34e: Stop using raw_input for python3 compat (authored by demon). · Explain WhyOct 27 2017, 7:13 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			scap/utils.py (6 lines)

Diff 2258

scap/utils.py

Loading...