Swap xrange fallback from six for plain ol' range
ClosedPublic

Authored by demon on Oct 30 2017, 7:30 AM.

Details

Reviewers
hashar
mmodell
Group Reviewers
Release-Engineering-Team
Commits
rMSCA35fe643d8f10: Swap xrange fallback from six for plain ol' range
Patch without arc
git checkout -b D861 && curl -L https://phabricator.wikimedia.org/D861?download=true | git apply
Summary

There's a performance hit in Python 2, but considering the size of our lists we're dealing with here I think it'll be negligible

Diff Detail

Repository
rMSCA Scap
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
demon created this revision.Oct 30 2017, 7:30 AM
Restricted Application added a reviewer: mmodell. · View Herald TranscriptOct 30 2017, 7:30 AM
Restricted Application added a reviewer: Release-Engineering-Team. · View Herald Transcript
Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript
hashar accepted this revision.Oct 30 2017, 8:08 AM

Indeed for a few elements, it does not matter to have the list generated first/held in memory :-)

This revision is now accepted and ready to land.Oct 30 2017, 8:08 AM
This revision was automatically updated to reflect the committed changes.