Logging: Don't treat % as format string unless there are format args
ClosedPublic

Authored by mmodell on Nov 6 2017, 10:53 PM.

Details

Reviewers
demon
Group Reviewers
Release-Engineering-Team
Commits
rMSCA321b4a274f27: Logging: Don't treat % as format string unless there are format args
Patch without arc
git checkout -b D871 && curl -L https://phabricator.wikimedia.org/D871?download=true | git apply
Summary

This should avoid a "not enough arguments for format string" error when logs contain a % in the message but no args are passed.

for example: https://www.irccloud.com/pastebin/aVkJJuka/

Test Plan

ran tox

Diff Detail

Repository
rMSCA Scap
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mmodell created this revision.Nov 6 2017, 10:53 PM
Restricted Application added a reviewer: Release-Engineering-Team. · View Herald TranscriptNov 6 2017, 10:53 PM
Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript
mmodell edited the summary of this revision. (Show Details)Nov 6 2017, 10:54 PM
awight added a subscriber: awight.Nov 6 2017, 10:56 PM

Good find!

demon accepted this revision.Nov 6 2017, 11:10 PM
This revision is now accepted and ready to land.Nov 6 2017, 11:10 PM
mmodell updated this revision to Diff 2307.Nov 7 2017, 1:02 AM

Restore sh library which was reverted due to the format string error.

  • Revert "Revert "Use sh library to wrap git commands.""
This revision was automatically updated to reflect the committed changes.