Change call to withFilterPHIDs after method rename
ClosedPublic

Authored by JeanFred on Nov 10 2017, 2:04 PM.

Details

Maniphest Tasks
T177051: "Call to undefined method" error due to using setFilterPHIDs instead of withFilterPHIDs
Reviewers
mmodell
Paladox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rPHSP3148c9ccb92a: Change call to withFilterPHIDs after method rename
Patch without arc
git checkout -b D876 && curl -L https://phabricator.wikimedia.org/D876?download=true | git apply
Summary

Clicking on a sprint name on /project/sprint/ results in:

>>> UNRECOVERABLE FATAL ERROR <<<
Call to undefined method PhabricatorFeedQuery::setFilterPHIDs()
/phabricator/libext/Sprint/src/controller/SprintProjectProfileController.php:79
┻━┻ ︵ ¯\_(ツ)_/¯ ︵ ┻━┻

This is because the method setFilterPHIDs was renamed to withFilterPHIDs
in rPHAB2d79229.

Ref T177051

Test Plan

Check syntax for possible typos. Deploy and see if it works.

Diff Detail

Repository
rPHSP phabricator-Sprint
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
JeanFred created this revision.Nov 10 2017, 2:04 PM
Restricted Application added a reviewer: Restricted Owners Package.Nov 10 2017, 2:04 PM
Paladox accepted this revision.Nov 10 2017, 2:39 PM
This revision is now accepted and ready to land.Nov 10 2017, 2:39 PM

Thanks for approving! I’m afraid I cannot land this though.

$ arc land
Landing current branch 'T177051'.
 TARGET  Landing onto "master", the default target under git.
 REMOTE  Using remote "origin", the default remote under git.
 FETCH  Fetching origin/master...
This commit will be landed:

      - b4f4e99 Change call to withFilterPHIDs after method rename

Landing revision 'D876: Change call to withFilterPHIDs after method rename'...
 BUILDS PASSED  Harbormaster builds for the active diff completed successfully.
 PUSHING  Pushing changes to "origin/master".

Username for 'https://phabricator.wikimedia.org': JeanFred
Password for 'https://JeanFred@phabricator.wikimedia.org': 
fatal: unable to access 'https://phabricator.wikimedia.org/diffusion/PHSP/phabricator-sprint.git/': The requested URL returned error: 403
Usage Exception: Push failed! Fix the error and run "arc land" again.

Yep, I believe @mmodell can only land this.

This revision was automatically updated to reflect the committed changes.