Do not include Debian revision in version.py
ClosedPublic
Actions

Authored by fgiunchedi on Nov 13 2017, 9:16 AM.

Details

Reviewers

mmodell
thcipriani

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Release-Engineering-Team

Commits

rMSCA7cb7593fade7: Do not include Debian revision in version.py

Patch without arc

git checkout -b D877 && curl -L https://phabricator.wikimedia.org/D877?download=true | git apply

Summary

Match previous scap releases

Diff Detail

Repository

rMSCA Scap

Branch

release

Lint

Lint Errors

Excuse: minimal diff

Severity	Location	Code	Message
Error	scap/version.py:1	E225	PEP8 E225

Unit

Unit Tests OK

Build Status

Buildable 2513
Build 4143: docker-diffs	Jenkins
Build 4142: differential-jessie	Jenkins
Build 4141: arc lint + arc unit

Event Timeline

fgiunchedi created this revision.Nov 13 2017, 9:16 AM

Restricted Application added a reviewer: Restricted Owners Package.Nov 13 2017, 9:16 AM

Restricted Application added a reviewer: Release-Engineering-Team. · View Herald TranscriptNov 13 2017, 9:16 AM

Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript

cc T127762

Build has FAILED

Link to build: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/847/
See console output for more information: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/847/console

Build has FAILED

Link to build: https://integration.wikimedia.org/ci/job/differential-docker-test/346/
See console output for more information: https://integration.wikimedia.org/ci/job/differential-docker-test/346/console

I spotted this because git-buildpackage would fail to build a source package lamenting "upstream changes" found, and indeed version.py was changed in the debian/3.7.2-1 git tag. Not having the Debian revision in version.py matches what we've been doing for other scap releases too.

thcipriani accepted this revision.Nov 13 2017, 3:52 PM

This revision is now accepted and ready to land.Nov 13 2017, 3:52 PM