Fix PEP8 E225 (missing whitespace around operator)
ClosedPublic

Authored by mmodell on Nov 13 2017, 5:26 PM.

Details

Reviewers
thcipriani
demon
hashar
Group Reviewers
Release-Engineering-Team
Commits
rMSCAe6eb25d317f2: Fix PEP8 E225 (missing whitespace around operator)
Patch without arc
git checkout -b D878 && curl -L https://phabricator.wikimedia.org/D878?download=true | git apply
Summary

This script generates code which has a lint error

Test Plan

untested

Diff Detail

Repository
rMSCA Scap
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mmodell created this revision.Nov 13 2017, 5:26 PM
Restricted Application added a reviewer: Release-Engineering-Team. · View Herald TranscriptNov 13 2017, 5:26 PM
Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript
demon accepted this revision.Nov 15 2017, 5:14 PM

Idk why it won't build, but the change itself is fine.

This revision is now accepted and ready to land.Nov 15 2017, 5:14 PM
hashar requested changes to this revision.Nov 15 2017, 5:37 PM
hashar added a subscriber: hashar.
$ flake8 <(echo "__version__= '$VERSION'")
/dev/fd/63:1:12: E225 missing whitespace around operator

The warning is about having spaces around the operator. It is still missing one before =. ;]

This revision now requires changes to proceed.Nov 15 2017, 5:37 PM
mmodell updated this revision to Diff 2327.Nov 15 2017, 9:01 PM

now with moar spaces ...

hashar accepted this revision.Nov 15 2017, 9:08 PM

better :]

This revision is now accepted and ready to land.Nov 15 2017, 9:08 PM
This revision was automatically updated to reflect the committed changes.