Fix compile() mode
ClosedPublic

Authored by demon on Nov 16 2017, 9:02 PM.

Details

Reviewers
mmodell
thcipriani
Group Reviewers
Release-Engineering-Team
Commits
rMSCA58310a4ba316: Fix compile() mode
Patch without arc
git checkout -b D883 && curl -L https://phabricator.wikimedia.org/D883?download=true | git apply
Summary

There's more than a single statement in version.py

Diff Detail

Repository
rMSCA Scap
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
demon created this revision.Nov 16 2017, 9:02 PM
Restricted Application added a reviewer: mmodell. · View Herald TranscriptNov 16 2017, 9:02 PM
Restricted Application added a reviewer: Release-Engineering-Team. · View Herald Transcript
Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript
demon requested review of this revision.Nov 16 2017, 9:04 PM
thcipriani accepted this revision.Nov 17 2017, 4:37 PM
thcipriani added a subscriber: thcipriani.

Works in testing. python setup.py install works fine, scap version gives me the right thing:

scap (arcpatch-D883) 10s                                                                                                                                                 
(.venv)(/^ヮ^)/*:・゚✧ scap version                                                                                                                                       
3.7.0-dev

There's more than a single statement in version.py

I think we should revisit that.

This revision is now accepted and ready to land.Nov 17 2017, 4:37 PM
demon added a comment.Nov 17 2017, 4:52 PM

There's more than a single statement in version.py

I think we should revisit that.

Tbh, I don't like having it as an executable python file at all. I'd much rather have it as a single file that we read as needed. It's not like we check versions in a tight loop or anything where the disk IO would be noticeable.

This revision was automatically updated to reflect the committed changes.