Drop basestring check for terminal arguments
ClosedPublic

Authored by demon on Nov 17 2017, 2:35 AM.

Details

Reviewers
mmodell
thcipriani
Group Reviewers
Release-Engineering-Team
Commits
rMSCA3ad58c1ecbf5: Drop basestring check for terminal arguments
Patch without arc
git checkout -b D885 && curl -L https://phabricator.wikimedia.org/D885?download=true | git apply
Summary

If we're already a string, converting to a string isn't a problem. Ensures py3 compat since basestring doesn't exist

Diff Detail

Repository
rMSCA Scap
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
demon created this revision.Nov 17 2017, 2:35 AM
Restricted Application added a reviewer: mmodell. · View Herald TranscriptNov 17 2017, 2:35 AM
Restricted Application added a reviewer: Release-Engineering-Team. · View Herald Transcript
Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript
demon requested review of this revision.Nov 17 2017, 2:36 AM
thcipriani accepted this revision.Nov 17 2017, 4:27 PM
This revision is now accepted and ready to land.Nov 17 2017, 4:27 PM
This revision was automatically updated to reflect the committed changes.