Swap Exception.message for str(Exception) calls
ClosedPublic

Authored by demon on Nov 17 2017, 6:32 PM.

Details

Reviewers
mmodell
Group Reviewers
Release-Engineering-Team
Commits
rMSCA869267c4ca9f: Swap Exception.message for str(Exception) calls
Patch without arc
git checkout -b D888 && curl -L https://phabricator.wikimedia.org/D888?download=true | git apply
Summary

Python decided that storing the exception message as...you know...a variable named message... wasn't a good idea. So they deprecated it in Python 2.6. It went away entirely in Python 3.

I don't quite understand why, but there you go.

At least the fix is easy

Test Plan

Ran some tests

Revert Plan

Just revert it

Diff Detail

Repository
rMSCA Scap
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
demon created this revision.Nov 17 2017, 6:32 PM
Restricted Application added a reviewer: mmodell. · View Herald TranscriptNov 17 2017, 6:32 PM
Restricted Application added a reviewer: Release-Engineering-Team. · View Herald Transcript
Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript
demon requested review of this revision.Nov 17 2017, 6:33 PM
demon updated this revision to Diff 2345.Nov 17 2017, 6:33 PM
  • Actually remove the offending variable from deploy.py
mmodell accepted this revision.Dec 1 2017, 12:02 PM
This revision is now accepted and ready to land.Dec 1 2017, 12:02 PM
This revision was automatically updated to reflect the committed changes.