Consistently define all attributes in __init__()
ClosedPublic

Authored by demon on Nov 17 2017, 8:46 PM.

Details

Reviewers
mmodell
Group Reviewers
Release-Engineering-Team
Commits
rMSCA908ac8101a0b: Consistently define all attributes in __init__()
Patch without arc
git checkout -b D889 && curl -L https://phabricator.wikimedia.org/D889?download=true | git apply
Summary

Considered proper form, and ensures we don't accidentally access something before it's been defined

Diff Detail

Repository
rMSCA Scap
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
demon created this revision.Nov 17 2017, 8:46 PM
Restricted Application added a reviewer: mmodell. · View Herald TranscriptNov 17 2017, 8:46 PM
Restricted Application added a reviewer: Release-Engineering-Team. · View Herald Transcript
Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript
demon requested review of this revision.Nov 17 2017, 8:48 PM
mmodell accepted this revision.Dec 1 2017, 12:01 PM
This revision is now accepted and ready to land.Dec 1 2017, 12:01 PM
This revision was automatically updated to reflect the committed changes.