Moving lint-related stuff out of the weird utils/tasks
ClosedPublic

Authored by demon on Nov 22 2017, 11:25 PM.

Details

Reviewers
mmodell
Group Reviewers
Release-Engineering-Team
Commits
rMSCA0d2afa233f3e: Moving lint-related stuff out of the weird utils/tasks
Patch without arc
git checkout -b D891 && curl -L https://phabricator.wikimedia.org/D891?download=true | git apply
Summary

Dedicated lint module can contain stuff like this. Will make it easier to add more, potentials for projects to enable/disable specific ones later on.

Test Plan

Ran some unit tests, but needs a few deploys in beta to make sure I didn't miss something

Diff Detail

Repository
rMSCA Scap
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
demon created this revision.Nov 22 2017, 11:25 PM
Restricted Application added a reviewer: mmodell. · View Herald TranscriptNov 22 2017, 11:25 PM
Restricted Application added a reviewer: Release-Engineering-Team. · View Herald Transcript
Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript
demon requested review of this revision.Nov 22 2017, 11:27 PM
demon updated this revision to Diff 2349.Nov 22 2017, 11:56 PM
  • Add some docs, plus make check_valid_syntax only accept a single path parameter
mmodell accepted this revision.Dec 1 2017, 12:00 PM
This revision is now accepted and ready to land.Dec 1 2017, 12:00 PM
This revision was automatically updated to reflect the committed changes.