Disable single edit tab for plwiki
AbandonedPublic

Authored by TerraCodes on Nov 23 2017, 5:02 AM.

Details

Maniphest Tasks
T181045: Enable both "edit" and "edit code" tabs in Polish Wikipedia
Reviewers
None
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Patch without arc
git checkout -b D892 && curl -L https://phabricator.wikimedia.org/D892?download=true | git apply

Diff Detail

Repository
rOMWC Wikimedia - MediaWiki Config
Branch
arcpatch-D892
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 2545
Build 4207: arc lint + arc unit
TerraCodes created this revision.Nov 23 2017, 5:02 AM
Restricted Application added a reviewer: Restricted Owners Package.Nov 23 2017, 5:02 AM
TerraCodes added a comment.EditedNov 23 2017, 5:10 AM

(very new with arc, sorry for any errors/issues I caused/created)

You need to also remove from 'wmgVisualEditorSingleEditTabSwitchTime' array.

TerraCodes updated this revision to Diff 2352.Nov 23 2017, 5:47 AM

update wmgVisualEditorSingleEditTabSwitchTime too

hashar added a subscriber: hashar.Nov 23 2017, 11:13 AM

rOMWC is just a mirror of the Gerrit repository operations/mediawiki-config.git. I am actually surprised Differential accepted a diff there.

Please close this and resubmit it to Gerrit https://www.mediawiki.org/wiki/Gerrit

TerraCodes abandoned this revision.EditedNov 23 2017, 8:46 PM
In D892#17766, @hashar wrote:

rOMWC is just a mirror of the Gerrit repository operations/mediawiki-config.git. I am actually surprised Differential accepted a diff there.

Please close this and resubmit it to Gerrit https://www.mediawiki.org/wiki/Gerrit

It has an .arcconfig and an .arclint in it, so I figured that it would work here too. Also submitted via gerrit.

hashar added a subscriber: demon.Nov 23 2017, 10:09 PM

rOMWC has an .arcconfig and an .arclint in it, so I figured that it would work here too. Also submitted via gerrit.

Ahh that explains the confusion thanks. I guess we will want to delete both files unless they have a specific purpose (unlikely).

@demon any idea why we would need Arcanist files in operations/mediawiki-config ?

Cuz I thought about moving this repo to Differential but never did. Could probably just drop them.