Fix "Call to a member function hasAnyProperties() on boolean"
DraftPublic

Authored by Paladox on Nov 27 2017, 8:14 PM.
  • This draft revision will not be submitted for review because 1 build(s) failed: Build 4221: differential-jessie.
  • Fix build failures and update the revision.

Details

Maniphest Tasks
T181428: If elasticsearch phabricator indices do not exist, phab throws an error
Reviewers
mmodell
Patch without arc
git checkout -b D898 && curl -L https://phabricator.wikimedia.org/D898?download=true | git apply
Summary

Adds an if check to make sure that if it returns false
it wont call hasAnyProperties.

Bug: T181428
Change-Id: I7e7da7e5a97e933444e2881681d3e5f98dbff294

Diff Detail

Repository
rPHAB Phabricator
Branch
wmf/stable
Lint
Lint SkippedExcuse: Same as before
Unit
Unit Tests Skipped
Build Status
Buildable 2552
Build 4221: differential-jessieJenkins
Build 4220: arc lint + arc unit
Paladox created this revision.Nov 27 2017, 8:14 PM
Restricted Application added a reviewer: mmodell. · View Herald TranscriptNov 27 2017, 8:14 PM

@mmodell hi, could you review please?

Also on the sideline can drafts be disabled as they are waiting for tests to pass but this is not how it works in gerrit thus making this workflow harder to use.