scap.sh logging is alarming
ClosedPublic

Authored by thcipriani on Dec 11 2017, 4:07 PM.

Details

Maniphest Tasks
T182643: cache_git_info (from e.g. scap sync-file) is way way too verbose
Reviewers
mmodell
demon
hashar
Group Reviewers
Release-Engineering-Team
Commits
rMSCA1d8a5d269a45: scap.sh logging is alarming
Patch without arc
git checkout -b D912 && curl -L https://phabricator.wikimedia.org/D912?download=true | git apply
Summary

The current logging levels make scap output look a bit alarming. Listing
all the git command output is probably something better left for when
someone passes the -v flag.

Test Plan

ran the code with -v and without -v

Diff Detail

Repository
rMSCA Scap
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
thcipriani created this revision.Dec 11 2017, 4:07 PM
Restricted Application added a reviewer: Release-Engineering-Team. · View Herald TranscriptDec 11 2017, 4:07 PM
Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript
thcipriani requested review of this revision.Dec 11 2017, 4:09 PM
demon accepted this revision.Dec 11 2017, 4:10 PM
This revision is now accepted and ready to land.Dec 11 2017, 4:10 PM
hashar accepted this revision.Dec 11 2017, 4:39 PM
hashar added a subscriber: hashar.

That was a bit too much :]

This revision was automatically updated to reflect the committed changes.