Make it more obvious when we are using `git_rev` in scap.cfg
ClosedPublic

Authored by mmodell on Dec 13 2017, 4:24 PM.

Details

Maniphest Tasks
T181661: Connection timeout from tin to new ores servers
Reviewers
akosiaris
thcipriani
awight
Group Reviewers
Release-Engineering-Team
Commits
rMSCAdae7fd15b3f6: Make it more obvious when we are using `git_rev` in scap.cfg
Patch without arc
git checkout -b D914 && curl -L https://phabricator.wikimedia.org/D914?download=true | git apply
Summary

This mostly just adds a couple of debug traces and upgrades one debug() to info()

This should hopefully make it more obvious when a deployment repo is using git_rev
setting in scap.cfg to deploy something like origin/master instead of HEAD.

See T181661 where debugging the issue was made more difficult than necessary.
I failed to notice that the rORESDEPLOY scap/scap.cfg had git_rev = origin/master
but they did did not have git_upstream_submodules.

I've also added docs for git_rev to repo_config.rst and reorganized
the "available config variables" table to better group related vars.

Diff Detail

Repository
rMSCA Scap
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mmodell created this revision.Dec 13 2017, 4:24 PM
Restricted Application added a reviewer: Release-Engineering-Team. · View Herald TranscriptDec 13 2017, 4:24 PM
Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript
mmodell requested review of this revision.Dec 13 2017, 4:26 PM
thcipriani accepted this revision.Dec 13 2017, 5:02 PM

docs build, logging changes look needed :)

This revision is now accepted and ready to land.Dec 13 2017, 5:02 PM
mmodell retitled this revision from Add a couple of debug traces and upgrade one .debug to .info to This should make it more obvious when we are using `git_rev` in scap.cfg.Dec 13 2017, 5:04 PM
mmodell edited the summary of this revision. (Show Details)
mmodell retitled this revision from This should make it more obvious when we are using `git_rev` in scap.cfg to Make it more obvious when we are using `git_rev` in scap.cfg.
This revision was automatically updated to reflect the committed changes.