Drop pep8 and pyflakes from linting, use flake8 to do both
ClosedPublic

Authored by demon on Dec 18 2017, 6:16 PM.

Details

Reviewers
mmodell
Group Reviewers
Release-Engineering-Team
Commits
rMSCAbdea954eb205: Drop pep8 and pyflakes from linting, use flake8 to do both
Patch without arc
git checkout -b D922 && curl -L https://phabricator.wikimedia.org/D922?download=true | git apply
Summary

Basically redo all of the test config into tox.ini. pytest.ini turns out to be redundant, same with setup.cfg. Long as all the tools run both standalone and within tox.ini, we're ok (everyone can read ini files).

Yay, less duplication, simplified all of this. Doing in prep of python 3.5 being added to our testing.

Test Plan

Ran tests & linting:

  • arc unit
  • arc lint --everything
  • flake8
  • pytest
  • tox -v

Diff Detail

Repository
rMSCA Scap
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
demon created this revision.Dec 18 2017, 6:16 PM
Restricted Application added a reviewer: mmodell. · View Herald TranscriptDec 18 2017, 6:16 PM
Restricted Application added a reviewer: Release-Engineering-Team. · View Herald Transcript
Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript
demon requested review of this revision.Dec 18 2017, 6:18 PM
demon updated this revision to Diff 2419.Dec 18 2017, 6:46 PM

Some fixes

demon updated this revision to Diff 2420.Dec 18 2017, 6:47 PM
  • Drop pyflakes from tox.ini too
demon updated this revision to Diff 2421.Dec 18 2017, 7:05 PM
  • - Don't need to set testdirs
demon edited the summary of this revision. (Show Details)Dec 18 2017, 7:09 PM
demon edited the test plan for this revision. (Show Details)
demon added inline comments.Dec 18 2017, 7:49 PM
test-requirements.txt
5

We might not need coverage explicitly listed, since we use pytest-cov.

mmodell accepted this revision.Dec 18 2017, 8:01 PM
This revision is now accepted and ready to land.Dec 18 2017, 8:01 PM
This revision was automatically updated to reflect the committed changes.