Fix up a few import errors
ClosedPublic

Authored by demon on Dec 19 2017, 7:16 PM.

Details

Reviewers
mmodell
Group Reviewers
Release-Engineering-Team
Commits
rMSCA2779bf9111ec: Fix up a few import errors
Patch without arc
git checkout -b D926 && curl -L https://phabricator.wikimedia.org/D926?download=true | git apply
Summary

Mostly in lesser-used codepaths

Diff Detail

Repository
rMSCA Scap
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
demon created this revision.Dec 19 2017, 7:16 PM
Restricted Application added a reviewer: mmodell. · View Herald TranscriptDec 19 2017, 7:16 PM
Restricted Application added a reviewer: Release-Engineering-Team. · View Herald Transcript
Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript
demon requested review of this revision.Dec 19 2017, 7:41 PM

I've seen this error before. It really makes me afraid that our dependencies are a house of cards about to fall over.

demon updated this revision to Diff 2427.Dec 19 2017, 8:27 PM

Fixed them for real, dropping the one from config.py

mmodell accepted this revision.Dec 19 2017, 9:51 PM

This is pygments version-dependent.

This revision is now accepted and ready to land.Dec 19 2017, 9:51 PM
mmodell added inline comments.Dec 19 2017, 10:03 PM
scap/utils.py
869 ↗(On Diff #2427)

We should probably add an apropriate pygments version to the requirements

demon added inline comments.Dec 19 2017, 11:40 PM
scap/utils.py
869 ↗(On Diff #2427)

I've never had a version of pygments where the old one worked, but pinning the version is probably best.

demon updated this revision to Diff 2432.Dec 20 2017, 4:06 AM

Dropped the utils.py fix for now

This revision was automatically updated to reflect the committed changes.