Only hide the login form if ldap is enabled.
DraftPublic

Authored by mmodell on Dec 23 2017, 12:03 AM.
  • This draft revision will not be submitted for review because 1 build(s) failed: Build 4414: differential-jessie.
  • Fix build failures and update the revision.

Details

Reviewers
Paladox
Commits
rPHAB12b9d17b042f: Only hide the login form if ldap is enabled.
Patch without arc
git checkout -b D938 && curl -L https://phabricator.wikimedia.org/D938?download=true | git apply
Summary

This works around a problem with testing instances (e.g. phab.wmflabs.org) that was introduced in rPHAB96701c4546bd39a1199784af168565e926bdd771
Because test instances don't use either ldap or oauth providers for login, the previous patch broke logins by hiding the form without rendering
the button which is needed to toggle the form visibility.

Test Plan

tested locally with my development instance.

Diff Detail

Repository
rPHAB Phabricator
Branch
wmf/stable
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 2644
Build 4414: differential-jessieJenkins
Build 4413: arc lint + arc unit