Log message to explain canary behavior
ClosedPublic

Authored by thcipriani on Jan 2 2018, 5:16 PM.

Details

Maniphest Tasks
T173146: Scap MediaWiki canaries should prompt to continue
Reviewers
mmodell
demon
Group Reviewers
Release-Engineering-Team
Commits
rMSCAaacb6a542d6d: Log message to explain canary behavior
Patch without arc
git checkout -b D939 && curl -L https://phabricator.wikimedia.org/D939?download=true | git apply
Summary

Failing a deployment due to a small spike in error rates on a single
machine has proven to be too conservative in practice. As a result we
now only fail a deployment if a the number of failing canaries is above
a threshold.

A canary failure that doesn't halt a deployment; however, looks
confusing for users. This adds a log message that should explain why a
deployment is continuing and assure users that this is not a bug.

Fixes T173146

Diff Detail

Repository
rMSCA Scap
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
thcipriani created this revision.Jan 2 2018, 5:16 PM
Restricted Application added a reviewer: Release-Engineering-Team. · View Herald TranscriptJan 2 2018, 5:16 PM
Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript
thcipriani requested review of this revision.Jan 2 2018, 5:18 PM
demon accepted this revision.Jan 2 2018, 6:55 PM
This revision is now accepted and ready to land.Jan 2 2018, 6:55 PM
This revision was automatically updated to reflect the committed changes.