Page MenuHomePhabricator

Content-Disposition filename should be URL-encoded
ClosedPublic

Authored by Gilles on Jan 8 2018, 1:58 PM.

Details

Maniphest Tasks
T183907: Thumbor 500 while thumbnailing some webm files
Reviewers
fgiunchedi
Commits
rTHMBREXT8acacea9fd91: Content-Disposition filename should be URL-encoded
Patch without arc
git checkout -b D944 && curl -L https://phabricator.wikimedia.org/D944?download=true | git apply
Summary

Diff Detail

Repository
rTHMBREXT Thumbor Plugins
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Gilles created this revision.Jan 8 2018, 1:58 PM
Gilles added a comment.Jan 8 2018, 1:58 PM

Might not be the only problem with webm files that have a % character in their name, but this was failing on Vagrant. It's a start.

Gilles requested review of this revision.Jan 8 2018, 1:59 PM
fgiunchedi accepted this revision.Jan 8 2018, 3:12 PM
fgiunchedi added subscribers: ema, BBlack.

LGTM, cc @BBlack and @ema for information only

This revision is now accepted and ready to land.Jan 8 2018, 3:12 PM
This revision was automatically updated to reflect the committed changes.