Page MenuHomePhabricator

Confirmation box on removal of reviewers
Needs ReviewPublic

Authored by Nehajha on Jan 15 2018, 7:49 PM.

Details

Maniphest Tasks
T108597: Confirmation box on removal of reviewers who have filed reviews for a campaign
Reviewers
Niharika
bd808
Patch without arc
git checkout -b D946 && curl -L https://phabricator.wikimedia.org/D946?download=true | git apply
Summary

Added a method for deleting reviews of reviewers and confirmation box

Diff Detail

Repository
rWIEG wikimedia-iegreview
Branch
T108597
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 2696
Build 4501: differential-jessieJenkins
Build 4500: arc lint + arc unit

Event Timeline

public/js/campaign.js
12

Missing braces. The message should not be hardcoded. Change the message to say something like "Are you sure you want to remove these reviewers? Doing this will delete all of their past reviews."

public/js/campaign.js
12

I don't think we have a feature for localized js messages in this app yet. It's probably ok to hard code for now and create a task to add that later if we feel its really needed.

I just realized that the confirmation box should only appear while unchecking a reviewer. So, I have added confirmation for checkboxes.