Differential D952

Avoid over-escaping video URLs
ClosedPublic
Actions

Authored by Gilles on Jan 24 2018, 1:04 PM.

Tags

None

Subscribers

None

Details

Maniphest Tasks

T183907: Thumbor 500 while thumbnailing some webm files

Reviewers

Commits

rTHMBREXT2737d17060bf: Avoid over-escaping video URLs

Patch without arc

git checkout -b D952 && curl -L https://phabricator.wikimedia.org/D952?download=true | git apply

Summary

Diff Detail

Repository

rTHMBREXT Thumbor Plugins

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Gilles created this revision.Jan 24 2018, 1:04 PM

Harbormaster completed remote builds in B2702: Diff 2497.Jan 24 2018, 1:05 PM

Gilles requested review of this revision.Jan 24 2018, 1:05 PM

fgiunchedi added inline comments.Jan 31 2018, 12:08 PM

wikimedia_thumbor/loader/video/__init__.py
235	A comment explaining the reasoning/rationale would be nice to have here.

Add comment

Harbormaster completed remote builds in B2710: Diff 2505.Jan 31 2018, 12:14 PM

Fix wording

Harbormaster completed remote builds in B2711: Diff 2506.Jan 31 2018, 12:16 PM

fgiunchedi accepted this revision.Feb 1 2018, 9:57 AM

This revision is now accepted and ready to land.Feb 1 2018, 9:57 AM

Closed by commit rTHMBREXT2737d17060bf: Avoid over-escaping video URLs (authored by Gilles). · Explain WhyFeb 1 2018, 11:03 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			wikimedia_thumbor/loader/video/__init__.py (58 lines)

Diff 2515

wikimedia_thumbor/loader/video/init.py

Loading...