Page MenuHomePhabricator

Set cwd as a courtesy to fetch-check commands
AbandonedPublic

Authored by awight on Jan 30 2018, 9:24 PM.

Details

Reviewers
mmodell
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Release-Engineering-Team
Patch without arc
git checkout -b D955 && curl -L https://phabricator.wikimedia.org/D955?download=true | git apply
Summary

We chdir to the target repo path after fetching to make it easy to inspect the
outputs, or run scripts from the repo.

Smoke tests locally, but I haven't figured out how to write a proper automated
test.

Bug: T154612

Event Timeline

awight created this revision.Jan 30 2018, 9:24 PM
Restricted Application added a reviewer: Restricted Owners Package.Jan 30 2018, 9:24 PM
Restricted Application added a reviewer: mmodell. · View Herald TranscriptJan 30 2018, 9:24 PM
Restricted Application added a reviewer: Release-Engineering-Team. · View Herald Transcript
Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript
awight requested review of this revision.Jan 30 2018, 9:32 PM
awight updated this revision to Diff 2510.Jan 31 2018, 8:43 PM
  • Rewrite using the "cd" context manager
awight abandoned this revision.Feb 20 2018, 5:16 PM

D970: Add `script` check type and environment variables is a better patch, and has been merged :-)