Page MenuHomePhabricator

Improve Thumbor error logging
ClosedPublic

Authored by Gilles on Feb 5 2018, 10:19 AM.

Details

Maniphest Tasks
T186492: Improve Thumbor error logging
Reviewers
fgiunchedi
Commits
rTHMBREXT38dfadc6d2f1: Improve Thumbor error logging
Patch without arc
git checkout -b D961 && curl -L https://phabricator.wikimedia.org/D961?download=true | git apply
Summary

Refs T186492

Diff Detail

Repository
rTHMBREXT Thumbor Plugins
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Gilles created this revision.Feb 5 2018, 10:19 AM
Gilles requested review of this revision.Feb 5 2018, 10:19 AM
fgiunchedi added inline comments.Feb 5 2018, 12:23 PM
wikimedia_thumbor/logging/filter/error/error.py
9

The referenced task mentions duplicated logging messages, though I was looking at logstash now and I don't see duplicated exceptions. Meaning this would prevent tracebacks from being logged into logstash, which I believe we want instead?

Gilles added inline comments.Feb 5 2018, 1:40 PM
wikimedia_thumbor/error_handlers/logstash/logstash.py
23

Traceback added here

wikimedia_thumbor/logging/filter/error/error.py
9

Right now there's a log entry with the traceback and one without for the same error. This would leverage logstash to have a single log entry with all that information.

fgiunchedi accepted this revision.Feb 5 2018, 1:58 PM
This revision is now accepted and ready to land.Feb 5 2018, 1:58 PM
This revision was automatically updated to reflect the committed changes.