Page MenuHomePhabricator

Handle default git_binary_manager of None
ClosedPublic

Authored by thcipriani on Feb 5 2018, 4:43 PM.

Details

Reviewers
demon
mmodell
Group Reviewers
Release-Engineering-Team
Commits
rMSCA954541b6d93c: Handle default git_binary_manager of None
Patch without arc
git checkout -b D964 && curl -L https://phabricator.wikimedia.org/D964?download=true | git apply
Summary

If there is no git_binary_manager set (which is the default), the
current code explodes trying to iterate over a NoneType object.

Fixes: T186532

Diff Detail

Repository
rMSCA Scap
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

thcipriani created this revision.Feb 5 2018, 4:43 PM
Restricted Application added a reviewer: Release-Engineering-Team. · View Herald TranscriptFeb 5 2018, 4:43 PM
Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript
thcipriani requested review of this revision.Feb 5 2018, 4:47 PM
demon accepted this revision.Feb 5 2018, 8:53 PM
This revision is now accepted and ready to land.Feb 5 2018, 8:53 PM
This revision was automatically updated to reflect the committed changes.