Page MenuHomePhabricator

Little bit of debian/control cleanup to prep for py3 transition
ClosedPublic

Authored by demon on Feb 16 2018, 1:50 AM.

Details

Reviewers
mmodell
Group Reviewers
Release-Engineering-Team
Commits
rMSCAdd89f026e3ab: Little bit of debian/control cleanup to prep for py3 transition
Patch without arc
git checkout -b D979 && curl -L https://phabricator.wikimedia.org/D979?download=true | git apply
Summary

Based on https://gerrit.wikimedia.org/r/#/c/387544/ where conftool supported both python 2 and 3, let's do a little bit of work to cleanup our debian setup.

  • Move X-Python-Version to the top section
  • Denote that this is a python2 version of the package
  • Newlines everywhere for legibility
  • Add ${shlibs:Depends}
  • Breaks and and Provides sections
  • Bump python-all minimum version to 2.7
  • Swap architecture from all to any

Todo:

  • Rename package to python-conftool?
  • Can we use dh_python to handle the dependency list for us rather than duplicating?
  • Can we use entry_points in setup.py and drop bin/scap?
Test Plan

Untested

Diff Detail

Repository
rMSCA Scap
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

demon created this revision.Feb 16 2018, 1:50 AM
Restricted Application added a reviewer: mmodell. · View Herald TranscriptFeb 16 2018, 1:50 AM
Restricted Application added a reviewer: Release-Engineering-Team. · View Herald Transcript
Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript
demon requested review of this revision.Feb 16 2018, 1:51 AM
mmodell accepted this revision.Mar 12 2018, 11:06 PM
This revision is now accepted and ready to land.Mar 12 2018, 11:06 PM
This revision was automatically updated to reflect the committed changes.