Page MenuHomePhabricator

Init params must match for all checktypes
ClosedPublic

Authored by thcipriani on Feb 20 2018, 5:57 PM.

Details

Reviewers
mmodell
demon
thcipriani
Group Reviewers
Release-Engineering-Team
Commits
rMSCA97dd3ca98c96: Init params must match for all checktypes
Patch without arc
git checkout -b D980 && curl -L https://phabricator.wikimedia.org/D980?download=true | git apply
Summary

Since a check now runs with a few added environment variables, the
signature of the __init__ function of all checks must be the same.

Fixes: T187815

Diff Detail

Repository
rMSCA Scap
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

thcipriani created this revision.Feb 20 2018, 5:57 PM
Restricted Application added a reviewer: Release-Engineering-Team. · View Herald TranscriptFeb 20 2018, 5:57 PM
Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript
thcipriani requested review of this revision.Feb 20 2018, 5:58 PM
thcipriani accepted this revision.Feb 20 2018, 6:00 PM

I was able to recreate the problem locally and fix it with this patch.

This revision is now accepted and ready to land.Feb 20 2018, 6:00 PM
This revision was automatically updated to reflect the committed changes.