Page MenuHomePhabricator

Remove `scap hhvm-graceful`
ClosedPublic

Authored by demon on Feb 21 2018, 8:03 PM.

Details

Reviewers
mmodell
Group Reviewers
Release-Engineering-Team
Commits
rMSCA815ff7cfae6e: Remove `scap hhvm-graceful`
Patch without arc
git checkout -b D982 && curl -L https://phabricator.wikimedia.org/D982?download=true | git apply
Summary

A scary and undocumented command. We would basically never want a deployer to run a rolling restart of all HHVM processes. That's what ops is for. Also: HHVM is going away.

Test Plan

Don't use it anymore

Diff Detail

Repository
rMSCA Scap
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

demon created this revision.Feb 21 2018, 8:03 PM
Restricted Application added a reviewer: mmodell. · View Herald TranscriptFeb 21 2018, 8:03 PM
Restricted Application added a reviewer: Release-Engineering-Team. · View Herald Transcript
Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript
demon requested review of this revision.Feb 21 2018, 8:04 PM
mmodell accepted this revision.Feb 21 2018, 10:50 PM

+1 remove.

I believe that this one is not only unused but actually dangerous

This revision is now accepted and ready to land.Feb 21 2018, 10:50 PM
This revision was automatically updated to reflect the committed changes.