Page MenuHomePhabricator

Remove `scap l10n-update`
ClosedPublic

Authored by demon on Feb 21 2018, 8:10 PM.

Details

Reviewers
mmodell
Group Reviewers
Release-Engineering-Team
Commits
rMSCA892c4f5c8fd9: Remove `scap l10n-update`
Patch without arc
git checkout -b D983 && curl -L https://phabricator.wikimedia.org/D983?download=true | git apply
Summary

L10nupdate doesn't use this. It rebuilds files itself/using MW (as it should), then uses sync-l10n. That's all fantastic. I don't exactly see a reason why a deployer would want to rebuild l10n just on the master and then sync them. In that case...why not just scap sync

Looking in the SAL, I find no instances of anyone using this, so we should be cool

Diff Detail

Repository
rMSCA Scap
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

demon created this revision.Feb 21 2018, 8:10 PM
Restricted Application added a reviewer: mmodell. · View Herald TranscriptFeb 21 2018, 8:10 PM
Restricted Application added a reviewer: Release-Engineering-Team. · View Herald Transcript
Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript
demon requested review of this revision.Feb 21 2018, 8:12 PM

I'm still at: D656#13537 :)

Which is to say, folks have used it before and it's got a small footprint that mainly just exposes some often-used, well-tested code, in a standalone way, so the maintenance burden is small (extra SLOC). Also Hyrum's Law: all observable behaviors of your system will be depended on by somebody.

I believe that this command was helpful in debugging l10n sync issues in the past, however, it's not well documented or understood so if we keep it we should probably document it better.

I think retaining non-standard behaviors outside of scap sync is harmful in our ultimate quest to unify scap2 and scap3 style deployments.

Also: could easily be a scap plugin

yeah. I'm not attached to it, personally.

mmodell accepted this revision.Feb 22 2018, 12:16 AM
This revision is now accepted and ready to land.Feb 22 2018, 12:16 AM
This revision was automatically updated to reflect the committed changes.