Page MenuHomePhabricator

Move _get_master_targets() up a level to cli.Application
ClosedPublic

Authored by demon on Feb 27 2018, 12:01 AM.

Details

Reviewers
mmodell
thcipriani
Group Reviewers
Release-Engineering-Team
Commits
rMSCAfb936f5821cc: Move _get_master_targets() up a level to cli.Application
Patch without arc
git checkout -b D988 && curl -L https://phabricator.wikimedia.org/D988?download=true | git apply
Summary

All applications have a right to know who their masters are.

Test Plan

Looked at it with a magnifying glass

Diff Detail

Repository
rMSCA Scap
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

demon created this revision.Feb 27 2018, 12:01 AM
Restricted Application added a reviewer: mmodell. · View Herald TranscriptFeb 27 2018, 12:01 AM
Restricted Application added a reviewer: Release-Engineering-Team. · View Herald Transcript
Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript
demon requested review of this revision.Feb 27 2018, 12:04 AM
thcipriani accepted this revision.Feb 27 2018, 12:05 AM
thcipriani added a subscriber: thcipriani.

For me in 6 months:

no_justification thcipriani, andrewbogott: Step 1 of making commands locale-aware: https://phabricator.wikimedia.org/D988
This revision is now accepted and ready to land.Feb 27 2018, 12:05 AM
This revision was automatically updated to reflect the committed changes.